Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs Cryo/Suicide Amounts for TDM Gamemodes #22354

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Logs Cryo/Suicide Amounts for TDM Gamemodes #22354

merged 5 commits into from
Sep 19, 2023

Conversation

matttheficus
Copy link
Contributor

@matttheficus matttheficus commented Sep 11, 2023 •
edited
Loading

What Does This PR Do

Logs the amount of Cryos/Suicides for TDM Gamemodes (Nukies/Wiz/Ragin').

Why It's Good For The Game

I want proper data for this number instead of my anecdotal reeeeee'ing about it in Staff channels.

Changelog

NPFC

Contrabang
Contrabang reviewed Sep 11, 2023
View reviewed changes
code/game/machinery/cryopod.dm Outdated Show resolved Hide resolved
code/game/verbs/suicide.dm Outdated Show resolved Hide resolved
@matttheficus
Copy link
Contributor Author

Changed to: SSblackbox.record_feedback("nested tally", "TDM_quitouts", 1, list(SSticker.mode.name, "TDM Suicides"))

Unsure on if this is the nicest way to track properly, pinging some database nerds about it.

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Sep 11, 2023
@SteelSlayer SteelSlayer added the Administration This PR relates to ingame administration features label Sep 15, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Sep 15, 2023
Contrabang
Contrabang approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@Contrabang Contrabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Sep 18, 2023
@S34NW S34NW merged commit a325543 into ParadiseSS13:master Sep 19, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewcc lewcc lewcc left review comments

@S34NW S34NW S34NW approved these changes

@Sirryan2002 Sirryan2002 Sirryan2002 approved these changes

@Contrabang Contrabang Contrabang approved these changes

Assignees
No one assigned
Labels
-Status: Awaiting merge This PR is ready for merge Administration This PR relates to ingame administration features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@matttheficus @S34NW @Sirryan2002 @lewcc @Contrabang @ParadiseSS13-Bot @SteelSlayer