Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump TGUI dependencies, updates tooling #22410

Merged
merged 10 commits into from
Sep 22, 2023
Merged

Bump TGUI dependencies, updates tooling #22410

merged 10 commits into from
Sep 22, 2023

Conversation

S34NW
Copy link
Member

@S34NW S34NW commented Sep 14, 2023 •
edited
Loading

What Does This PR Do

  • Bumps TGUI dependencies. The big one being removal of prettierx 0.19, which has been abandoned for over 2 years now, in favor of prettier 3.0.3
  • Runs prettier in write mode over TGUI, bringing it into stylistic compliance (and causing major mass conflicts)
  • Adds tgui/bin/tgui-formatting.bat to make it easier for initial prettier conflicts to be resolved
  • Bakes in VSC build options for DM and TGUI (these might mess with user settings if already set? unsure)
  • Bumps CI to node 18 from node 12
  • tgui dev server is made to use legacy openssl as I can't find where to include a define for the digest function so we don't get the ERR_OSSL_EVP_UNSUPPORTED error. By consequence we also need --no-experimental-fetch or further things break.

I want to stress that no functionality changes have been made to TGUI code in this PR. It's all stylistic.
EDIT: I liked there are like 2 non-stylistic changes where things inside of maps are given keys so they are compliant. No real actual changes to end user from this though.

Why It's Good For The Game

Updated dependencies patches security issues. If we are staying with TGUI 3 for the foreseeable future, we should look after it.
We also have like, a ton of major vulnerability alerts due to current TGUI deps. No thank you.

Testing

Loaded a bunch of TGUIs, everything looked normal. Dev server works fine still.
Should still TM it as I don't 100% trust automated tools.

Changelog

NPFC

@ParadiseSS13-Bot ParadiseSS13-Bot added Testmerge Requested This PR has a pending testmerge request -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally TGUI This PR modifies TGUI, will conflict labels Sep 14, 2023
@SteelSlayer SteelSlayer added the Tools This updates tooling on the repository label Sep 15, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Sep 15, 2023
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Sep 19, 2023
@SteelSlayer SteelSlayer removed the Merge Conflict This PR is merge conflicted label Sep 19, 2023
Contrabang
Contrabang requested changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@Contrabang Contrabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the PR description to include the Node 18 change?

tgui/package.json Show resolved Hide resolved
tgui/packages/tgui/interfaces/BodyScanner.js Show resolved Hide resolved
tgui/packages/tgui/interfaces/ERTManager.js Show resolved Hide resolved
tgui/packages/tgui/interfaces/ERTManager.js Show resolved Hide resolved
tgui/packages/tgui/webpack.config.js Show resolved Hide resolved
.vscode/tasks.json Show resolved Hide resolved
Contrabang
Contrabang approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@Contrabang Contrabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Active This PR is currently testmerged on production label Sep 19, 2023
hal9000PR
hal9000PR approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@hal9000PR hal9000PR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuck it we ball

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Sep 21, 2023
lewcc
lewcc approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't seen any issues, it's probably fine

@hal9000PR hal9000PR merged commit 45bf2ff into ParadiseSS13:master Sep 22, 2023
15 checks passed
Furrior pushed a commit to ss220club/Paradise-SS220 that referenced this pull request Sep 23, 2023
@S34NW @Furrior
Bump TGUI dependencies, updates tooling (ParadiseSS13#22410)
b38afa4 
* bump deps to remove vulnerabilities

* new script who dis

* more changes to support it

* node 16

* node 18

* fixes CI

* prettier decided to do this

* stops the dev server exploding

* fixes dev server for real
@S34NW S34NW deleted the bump_deps branch December 24, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warriorstar-orion warriorstar-orion warriorstar-orion left review comments

@hal9000PR hal9000PR hal9000PR approved these changes

@lewcc lewcc lewcc approved these changes

@Contrabang Contrabang Contrabang approved these changes

@AffectedArc07 AffectedArc07 Awaiting requested review from AffectedArc07 AffectedArc07 is a code owner

Assignees
No one assigned
Labels
-Status: Awaiting merge This PR is ready for merge Testmerge Active This PR is currently testmerged on production Testmerge Requested This PR has a pending testmerge request TGUI This PR modifies TGUI, will conflict Tools This updates tooling on the repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@S34NW @warriorstar-orion @hal9000PR @lewcc @Contrabang @ParadiseSS13-Bot @SteelSlayer