Nt recruiter First DLC (emag and other tweaks) #22427

Henri215 · 2023-09-15T22:12:46Z

What Does This PR Do

PAID CONTENT (unlocked with emag)
The NT Recruiter Arcade can now be emagged, changing its name and description. Does the following:

Doubles the total amount of curriculums you must stamp to win (14).
Explodes if you get a game over.
Rewards: Nanotrasen recruiter custom medal and a chameleon stamp.

FREE CONTENT

Changed the emissive color from the base arcade green to white (dev note: ITS SCREEN IS WHITE NOT GREEN).
Vox species has been included into the game (dev note: We forgot to include them).
Very slightly tweaked some records.
Decreased slightly the volume of the music played on victory.
Increased the total amount of curriculums necessary for you to win 5 -> 7 (dev note: After observing the arcade being played we now believe this is the sweet spot for it, considering the amount of tickets it gives and how fast some players could win it)
Added a small 0.4 seconds cooldown to interactions (dev note: To prevent accidental clicks and spam of the sounds)

Why It's Good For The Game

Tweaks resulted from observation, look over "what does this PR do" for more explanation.

Images of changes

LOSING

failure.mp4

WINNING

winning.mp4

Testing

Emagged the arcade and played it, testing both defeat and victory.

Changelog

🆑 Henri215, BlackDog
add: The NT Recruiter arcade can now be emagged
tweak: NT Recruiter arcade: Number of curriculums have been increased (5 -> 7)
tweak: NT Recruiter arcade: Tweaked some species, records and sound volumes
/:cl:

Coolrune206 · 2023-09-16T01:17:12Z

Stealing an idea from someone else, but the NT Recruiter game should just terminate you off manifest if you lose it while it's emagged 😏

code/game/machinery/computer/arcade_games/recruiter.dm

DGamerL · 2023-09-17T11:40:06Z

Stealing an idea from someone else, but the NT Recruiter game should just terminate you off manifest if you lose it while it's emagged 😏

Agreed, and I'm definitely not biased about this idea

spacegeese · 2023-09-17T19:20:20Z

Vox species has been included into the game (dev note: We forgot to include them).

i like the notion that NT is extremely racist to vox but discrimination is not good for PR so they take their anger out by not including them in their arcade game

Burzah

lgtm!

code/game/machinery/computer/arcade_games/recruiter.dm

Co-authored-by: Luc <[email protected]>

lewcc

LGTM (I'm good to me)

* New NT Recruiter update * Adding emag effect for the arcade + other tweaks * tickets for reward too * ops * Medal prize! * adding sounds when losing! * increasing minimum bad max age * added small interaction cooldown * adjusting time * tgui rebuild * ah shit, here we go again * tgui rebuild * lets fix this * Apply suggestions from code review Co-authored-by: Luc <[email protected]> * tgui rebuild * tgui rebuild --------- Co-authored-by: Luc <[email protected]>

Henri215 added 4 commits September 15, 2023 15:17

New NT Recruiter update

f793ea2

Adding emag effect for the arcade + other tweaks

a687512

tickets for reward too

d1b6e5d

ops

bdd5c12

Henri215 added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Sep 15, 2023

ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally TGUI This PR modifies TGUI, will conflict labels Sep 15, 2023

Medal prize!

6839b70

Burzah reviewed Sep 16, 2023

View reviewed changes

code/game/machinery/computer/arcade_games/recruiter.dm Outdated Show resolved Hide resolved

Henri215 marked this pull request as ready for review September 16, 2023 17:53

adding sounds when losing!

12b167d

ParadiseSS13-Bot added the Sound This PR modifies the game sound label Sep 16, 2023

hal9000PR added the Feature This PR is a new addition to the game label Sep 16, 2023

ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Sep 17, 2023

increasing minimum bad max age

17d141c

Henri215 added 2 commits September 17, 2023 17:52

added small interaction cooldown

e887d47

adjusting time

1db6a10

github-actions bot added the Merge Conflict This PR is merge conflicted label Sep 19, 2023

ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Sep 19, 2023

Henri215 added 3 commits September 20, 2023 14:29

Merge branch 'master' into NT_recruiter_tweaks

709be10

tgui rebuild

1e1f4a7

ah shit, here we go again

923e074

Sirryan2002 approved these changes Sep 20, 2023

View reviewed changes

ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Sep 20, 2023

github-actions bot removed the Merge Conflict This PR is merge conflicted label Sep 21, 2023

Henri215 requested a review from Burzah September 21, 2023 01:22

Burzah approved these changes Sep 21, 2023

View reviewed changes

github-actions bot added the Merge Conflict This PR is merge conflicted label Sep 22, 2023

Henri215 added 3 commits September 22, 2023 13:24

Merge branch 'master' into NT_recruiter_tweaks

f8a188c

tgui rebuild

a64bfca

lets fix this

cd61880

github-actions bot removed the Merge Conflict This PR is merge conflicted label Sep 24, 2023

lewcc requested changes Sep 25, 2023

View reviewed changes

code/game/machinery/computer/arcade_games/recruiter.dm Outdated Show resolved Hide resolved

code/game/machinery/computer/arcade_games/recruiter.dm Outdated Show resolved Hide resolved

code/game/machinery/computer/arcade_games/recruiter.dm Outdated Show resolved Hide resolved

Apply suggestions from code review

aff6ce0

Co-authored-by: Luc <[email protected]>

ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting merge This PR is ready for merge labels Sep 25, 2023

github-actions bot added the Merge Conflict This PR is merge conflicted label Sep 25, 2023

Henri215 requested a review from lewcc September 25, 2023 23:48

Henri215 added 2 commits September 26, 2023 06:44

Merge branch 'master' into NT_recruiter_tweaks

85b34e4

tgui rebuild

f6fb984

github-actions bot removed the Merge Conflict This PR is merge conflicted label Sep 26, 2023

lewcc approved these changes Sep 28, 2023

View reviewed changes

ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Sep 29, 2023

github-actions bot added the Merge Conflict This PR is merge conflicted label Sep 30, 2023

Henri215 added 2 commits September 30, 2023 22:49

Merge branch 'master' into NT_recruiter_tweaks

c77f55f

tgui rebuild

bd0a908

github-actions bot removed the Merge Conflict This PR is merge conflicted label Oct 1, 2023

S34NW merged commit 85d8aee into ParadiseSS13:master Oct 1, 2023
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nt recruiter First DLC (emag and other tweaks) #22427

Nt recruiter First DLC (emag and other tweaks) #22427

Henri215 commented Sep 15, 2023 •

edited

Loading

Coolrune206 commented Sep 16, 2023

DGamerL commented Sep 17, 2023

spacegeese commented Sep 17, 2023 •

edited

Loading

Burzah left a comment

lewcc left a comment

Nt recruiter First DLC (emag and other tweaks) #22427

Nt recruiter First DLC (emag and other tweaks) #22427

Conversation

Henri215 commented Sep 15, 2023 • edited Loading

What Does This PR Do

Why It's Good For The Game

Images of changes

Testing

Changelog

Coolrune206 commented Sep 16, 2023

DGamerL commented Sep 17, 2023

spacegeese commented Sep 17, 2023 • edited Loading

Burzah left a comment

Choose a reason for hiding this comment

lewcc left a comment

Choose a reason for hiding this comment

Henri215 commented Sep 15, 2023 •

edited

Loading

spacegeese commented Sep 17, 2023 •

edited

Loading