Refactors transit tubes #22452
Merged
Refactors transit tubes #22452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sirryan2002
reviewed
Sep 18, 2023
ParadiseSS13-Bot
added
DeltaStation
hal9000PR
added
the
Refactor
ParadiseSS13-Bot
added
-Status: Awaiting review
lewcc
commented
Sep 20, 2023
Henri215
reviewed
Oct 14, 2023
lewcc
force-pushed
the
better-transit-tubes
branch
from
11a5892
to
f4d1547
Compare
lewcc
force-pushed
the
better-transit-tubes
branch
2 times, most recently
from
a810eac
to
b531b1a
Compare
S34NW
approved these changes
Oct 17, 2023
BR54FF
pushed a commit
to BR54FF/Paradise-SS220
that referenced
this pull request
Oct 23, 2023
* Rework transit tube pods to not use timers * please work * yes * henri review * Fix mapping mishaps * fix icon mishaps * re-adds missing intercomm
Oyu07
pushed a commit
to Oyu07/Paradise
that referenced
this pull request
Jan 2, 2024
* Rework transit tube pods to not use timers * please work * yes * henri review * Fix mapping mishaps * fix icon mishaps * re-adds missing intercomm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Refactors transit tubes to a pretty significant degree. Player-wise, they may be a tad slower, but they're gonna hopefully be a lot easier to work with map-wise and hopefully code-wise.
On the mapping side, mapping in transit tubes becomes significantly easier. I don't even want to think about how much fun it would have been in the past to map a new set of transit tubes, since you had to do all kinds of weird icon state stuff. Every directional icon was baked into an icon file, and you even had to add corners yourselves on diagonals.
Now, you just set the right dir for tubes, of which there are now plenty of helper subtypes for curves, diagonals, reversed pipes, etc. Code will automatically add the junction bits/decorations for corners and joints on init, even though they may not be immediately visible in a map editor.
On the coding side, transit tubes now no longer use sleeps or timers during their main movement loop, and instead use a small subsystem that fires once per tick. I've tried to be clever with usage so things are only added to the processing queue if they're actively moving, which should save a fair amount of processing time since tubes spend a lot of their time at stations.
A significant amount of the heavy structural improvements to icons and code came from /tg/'s implementation.
Why It's Good For The Game
Transit tube code is pretty crusty and old (most of it hasn't been touched for the past 9 years or so). This should hopefully bring it up to slightly more modern standards, and hopefully make things more performant going forward.
This should also hopefully make transit tubes easier to interact with on the mapping side, and possibly make them justifiable for use on the coding side (such as possibly adding them to the RPD or something).
Images of changes
DvhyJHyX.mp4
Testing
Loaded in all maps, and verified that the transit tubes (as configured) worked from roundstart. Also built a few transit mechanisms from scratch and verified they worked as intended.
Changelog
🆑
tweak: Transit tubes are now slightly slower
tweak: You can now empty out a transit pod with a crowbar
/:cl: