Fixes Newscaster Treatment of Wallets #27121
Open
+7
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use human/get_id_card proc instead of custom solution.
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
Henri215
approved these changes
Oct 19, 2024
| @@ -645,18 +645,10 @@ GLOBAL_LIST_EMPTY(allNewscasters) | |||
| /obj/machinery/newscaster/proc/get_scanned_user(mob/user) | |||
| . = list(name = "Unknown", security = user.can_admin_interact()) | |||
| if(ishuman(user)) | |||
| var/mob/living/carbon/human/M = user | |||
| var/mob/living/carbon/human/human_user = user | |||
| // No ID, no luck | |||
There was a problem hiding this comment.
Suggested change
| // No ID, no luck |
Related to the if(!M.wear_id) that is no longer here
ParadiseSS13-Bot
added
-Status: Awaiting merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Fixes #26357 (Newscaster does not recognize IDs inside wallets)
Simplyfies newscaster/proc/get_scanned_user
Moves proc/GetNameAndAssignmentFromId from a comms console related file to the ID card file
Why It's Good For The Game
One less bug
Makes a proc that's universally useful more discoverable
Images of changes
Testing
Created news channel with empty wallet in ID slot. Manage channel was available.
Put on ID directly. Manage channel was greyed out.
Put on ID in wallet. Manage channel was greyed out.
Created news channel with ID in wallet. Manage channel was available.
IIRC put on ID directly and manage channel was available. (I should have written this while I was testing.)
Removed ID. Manage channel was greyed out.
Logged into comms console with debugger ID. Made announcement. Job was shown correctly.
Same with ID in wallet.
Tried logging in with librarian ID. Unable.
Tried loggin in with empty wallet. Unable
Declaration
Changelog
🆑
fix: Newscaster now correctly handle wallets.
/:cl: