Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Python 3.11 #262

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Added support for Python 3.11 #262

merged 1 commit into from
Sep 18, 2023

Conversation

simkimsia
Copy link
Contributor

@simkimsia simkimsia commented Sep 8, 2023

Fixes #260.

@simkimsia
Copy link
Contributor Author

@mristin I am trying to understand this scrutinizer and i saw it got timed out.

image

I wish to self-remedy my own PR.

But I need some guidance. If you can help me to understand so I can self-diagnose and self-modify the PR, it will be great.

No hurry at all as I can wait.

Thank you

@mristin mristin changed the title 🚧chore: add support for python 3.11 Added support for Python 3.11 Sep 14, 2023
@mristin
Copy link
Collaborator

mristin commented Sep 14, 2023

@simkimsia

@mristin I am trying to understand this scrutinizer and i saw it got timed out.

Let me disable it.

Mypy dropped support for Python 3.7. I'll have to adapt the pre-commit script. Please give me some more time, as it is really busy around here.

@simkimsia
Copy link
Contributor Author

Please give me some more time, as it is really busy around here.

No worries. Take your time. Thank you for doing this python package

@mristin
Copy link
Collaborator

mristin commented Sep 15, 2023

@simkimsia I upgraded the individual dependencies, as it required some tweaks and knowledge about the intricacies of the implementation.

Please rebase your pull request on the latest master branch, and then it should work.

Related pull requests:

This patch introduces Python versions 3.11 in continuous
integration.

Signed-off-by: KimSia, Sim <[email protected]>
@simkimsia
Copy link
Contributor Author

@mristin I have made the changes. So now waiting for approval.

Branch no longer has conflicts

Also I noticed that you have a consistent style for writing the commit message which I have tried to follow.

Do you mind if I contribute to a doc that explains explicitly the commit message style? I have written this as separate issue at #270

@coveralls
Copy link

Coverage Status

coverage: 92.784% (+0.1%) from 92.656% when pulling 3384de4 on simkimsia:py311 into 5a7870b on Parquery:master.

@mristin mristin merged commit 4971253 into Parquery:master Sep 18, 2023
12 checks passed
@mristin
Copy link
Collaborator

mristin commented Sep 18, 2023

@simkimsia thanks a lot again! Should I release a patch version or you plan more features in the short term?

@simkimsia
Copy link
Contributor Author

Should I release a patch version or you plan more features in the short term?

your choice

i am still learning how to use this. I don't dare to suggest more features

mristin added a commit that referenced this pull request Oct 2, 2023
* Removed meta data files from setup.py (#262)
* Added support for python 3.11 (#260)
* Fixed in-progress set for async (#256)
@mristin mristin mentioned this pull request Oct 2, 2023
mristin added a commit that referenced this pull request Oct 2, 2023
* Removed meta data files from setup.py (#262)
* Added support for python 3.11 (#260)
* Fixed in-progress set for async (#256)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for python 3.11
3 participants