Incorrect handling of OperationCancelledException can causes hanging ingestion, unnoticed failing tasks, and no logging of timeouts #4780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich can cause the ingestion to never used incoming context tasks and hang.
… - only ignore cancellations set by caller
ramonsmits
force-pushed
the
hanging-ingestion
branch
from
1e56a0e to
9c249c9
Compare
src/Particular.LicensingComponent/AuditThroughput/AuditThroughputCollectorHostedService.cs
Show resolved
Hide resolved
andreasohlund
approved these changes
Feb 7, 2025
|
@andreasohlund Load tested this build for 12+ hours with multiple instances on this version and 6.3.0. All 6.3.0 instances eventually halted processing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following line in the logs can indicate that the instance eventually hangs: