Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy improvements #2077

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Proxy improvements #2077

wants to merge 6 commits into from

Conversation

bording
Copy link
Member

@bording bording commented Sep 24, 2024 •
edited
Loading

This PR adds the following features to the container host:

  • The reverse proxy can now be disabled by setting the ENABLE_REVERSE_PROXY environment variable to false.
  • The reverse proxy no longer assumes the structure of the URLs passed via the SERVICECONTROL_URL and MONITORING_URL settings will use the value as passed in.

NOTE: Regardless of the two changes above, the SERVICECONTROL_URL value is still inspected to see if it ends with /api/ and will append that as needed to ensure a valid URL.

Closes #2076

@bording bording marked this pull request as ready for review September 25, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidBoike DavidBoike DavidBoike approved these changes

@boblangley boblangley boblangley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ServicePulse container reverse proxy tweaks
3 participants
@bording @DavidBoike @boblangley