Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trapdoor, Door and Sculk Sensor BlockModelTypes #157

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

tomalbrc
Copy link
Contributor

@tomalbrc tomalbrc commented Oct 8, 2024

This adds BlockModelTypes for Trapdoors, Doors and Sculk Sensor BlockModelTypes.
Waxed copper trapdoors and doors get remapped to their non-waxed equivalent.
The powered block state property of vanilla doors is remapped to the non-powered equivalent.

The power property of sculk sensors together with permutations for sculk_sensor_phase and calibrated sculk sensors' facing properties result in the BlockModelTypes for SCULK_SENSOR_BLOCK and SCULK_SENSOR_BLOCK_WATERLOGGED.
I excluded the active value of sculk_sensor_phase since it emits particles on the client-side.

*_DOOR contains both the upper and lower halves of doors as well as open doors in other directions that align with the closed equivalent.

Previous unnecessary model definitions for tripwire were removed

BlockModelType amount
SCULK_SENSOR_BLOCK 150
SCULK_SENSOR_BLOCK_WATERLOGGED 150
TOP_TRAPDOOR 20
BOTTOM_TRAPDOOR 20
NORTH_TRAPDOOR 20
EAST_TRAPDOOR 20
SOUTH_TRAPDOOR 20
WEST_TRAPDOOR 20
TOP_TRAPDOOR_WATERLOGGED 20
BOTTOM_TRAPDOOR_WATERLOGGED 20
NORTH_TRAPDOOR_WATERLOGGED 20
EAST_TRAPDOOR_WATERLOGGED 20
SOUTH_TRAPDOOR_WATERLOGGED 20
WEST_TRAPDOOR_WATERLOGGED 20
NORTH_DOOR 160
EAST_DOOR 160
SOUTH_DOOR 160
WEST_DOOR 160

@tomalbrc tomalbrc marked this pull request as draft October 10, 2024 09:28
@tomalbrc tomalbrc marked this pull request as ready for review October 10, 2024 23:44
@Daniel99j2
Copy link

I would like to suggest to add the Fire "age" (Soul too)

@Patbox Patbox merged commit e8bf139 into Patbox:dev/1.21 Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants