Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading Screen #137

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Loading Screen #137

wants to merge 5 commits into from

Conversation

skate54345
Copy link
Member

No description provided.

src/js/module3.js Show resolved Hide resolved
src/js/module2.js Show resolved Hide resolved
src/js/module1.js Show resolved Hide resolved
src/js/module2.js Show resolved Hide resolved
src/js/module2.js Show resolved Hide resolved
Copy link
Member

@chance-nelson chance-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more or less useless, since loading times between modules are so small. Perhaps make it appear in the foreground during execution.

@skate54345 skate54345 requested a review from chance-nelson May 6, 2019 22:17
turanoo
turanoo previously approved these changes May 9, 2019
@skate54345
Copy link
Member Author

Please merge

chance-nelson
chance-nelson previously approved these changes May 10, 2019
@skate54345 skate54345 dismissed stale reviews from chance-nelson and turanoo via a86a6b2 May 11, 2019 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants