final final test

Paul1365972 · Jan 14, 2025 · 0c9abbf · 0c9abbf
1 parent 5998407
commit 0c9abbf
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -42,7 +42,7 @@ jobs:
 
       - name: Build
         env:
-          CARGO_TARGET_X86_64_PC_WINDOWS_MSVC_LINKER: rust-lld
+          CARGO_TARGET_X86_64_PC_WINDOWS_MSVC_LINKER: lld-link
         run: cargo build --release --target ${{ matrix.target }}
 
       - name: Upload artifact

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -27,7 +27,6 @@ jobs:
   clippy:
     name: Clippy lints
     runs-on: ubuntu-latest
-    continue-on-error: true
     steps:
       - uses: actions/checkout@v4
 
@@ -40,7 +39,8 @@ jobs:
         uses: Swatinem/rust-cache@v2
 
       - name: Run clippy
-        run: cargo clippy --all-features --all-targets -- -D warnings
+        # If we ever get around to fix everything clippy complains about we can start failing on warning via: -- -D warnings
+        run: cargo clippy --all-features --all-targets
 
   test:
     name: Run tests

diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
@@ -10,8 +10,6 @@ jobs:
     runs-on: ubuntu-latest
     permissions:
       contents: read
-      packages: write
-    if: secrets.DOCKER_HUB_USERNAME && secrets.DOCKER_HUB_ACCESS_TOKEN
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -20,13 +18,12 @@ jobs:
         id: meta
         uses: docker/metadata-action@v5
         with:
-          images: |
-            ${{ secrets.DOCKER_HUB_USERNAME }}/mchprs
+          images: ${{ secrets.DOCKER_HUB_USERNAME }}/mchprs
           tags: |
             type=raw,value=latest,enable={{is_default_branch}}
-            type=semver,pattern={{version}}
+            type=semver,pattern={{major}}.{{minor}}.{{patch}}
             type=semver,pattern={{major}}.{{minor}}
-            type=sha,prefix=,format=short
+            type=sha,format=short
 
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v3
@@ -52,4 +49,4 @@ jobs:
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
           cache-from: type=gha
-          cache-to: type=gha,mode=max
+          cache-to: type=gha