-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fix for basic relative URLs and support variables in servers URLs #69
base: master
Are you sure you want to change the base?
Conversation
This resolves #59 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR @udamir!
please see my comments
Move this improvement to next version
+1 on this fix |
CI is passing locally, merging. |
@kobik Could you please merge this? |
What I need to do to pass ci/circleci checks? |
Bump on this change -- anything blocking it besides a review? I can add a commit if needed. |
@udamir @goldsziggy This still needs tests, and also conflicts need to be resolved now that https://github.com/PayU/api-schema-builder/pull/67/files is merged, which I believe will be superseded by this PR - but you can definitely reuse the tests that were created for that PR. |
I don't want to put a specific url of server in OpenAPI file, as it can be used in different environments, so I use the following:
On init method I get the error: