fix content type validation for OAS3 #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the contentTypeValidation option is currently broken for OAS3 schemas, this PR fixes it
current code throws on relative server URLs, i.e.:
servers:
- url: /v2
fix it by providing a dummy base to URL
|
Hi @mildsunrise , thank you very much for your PR! can you please fix the lint issues that are failing the build? edit: can you also please add relevant tests? |
kibertoad
reviewed
May 11, 2021
| @@ -37,7 +37,7 @@ function buildValidations(referenced, dereferenced, receivedOptions) { | |||
| const schemas = {}; | |||
|
|
|||
| const basePaths = dereferenced.servers && dereferenced.servers.length | |||
| ? dereferenced.servers.map(({ url }) => new URL(url).pathname) | |||
| ? dereferenced.servers.map(({ url }) => new URL(url, 'http://foo').pathname) | |||
There was a problem hiding this comment.
there has to be an origin, but any origin works (we just want to extract the pathname)
kobik
requested changes
May 11, 2021
| @@ -123,8 +123,10 @@ function buildRequestValidator(referenced, dereferenced, currentPath, currentMet | |||
| } | |||
|
|
|||
| if (localParameters.length > 0 || options.contentTypeValidation) { | |||
| requestSchema.parameters = buildParametersValidation(localParameters, | |||
| dereferenced.paths[currentPath][currentMethod].consumes || dereferenced.paths[currentPath].consumes || dereferenced.consumes, options); | |||
| const contentTypes = isOpenApi3 ? | |||
There was a problem hiding this comment.
i know the code base isn't pretty to say least, but i suggest that will try not to make it even harder to read. what do you say about extracting this to a function?
There was a problem hiding this comment.
i'd also suggest adding a test for covering both cases when content type exists and missing from the request body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the contentTypeValidation option is currently broken for OAS3 schemas, this PR fixes it