PAE-845 Add custom prerequisites functionality to improve learner experience #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anfbermudezme
changed the title
anfbermudezme
changed the base branch from
pearson-release/juniper.stage
to
open-release/juniper.stage
|
There is another page where you have to extend this feature in order to be consistent. Please take a look at course_about.html and check the about course page lms-site/courses/{id-course-with-prerequisite}/about. So here, It will still be behaving as normal. @anfbermudezme
|
Jacatove
suggested changes
Nov 29, 2021
edx-platform/pearson-pathways-theme/lms/templates/dashboard/_dashboard_course_listing.html
Outdated
Show resolved
Hide resolved
anfbermudezme
force-pushed
the
pearson/PAE-845
branch
from
c9b2bd8
to
8bbe3fb
Compare
anfbermudezme
force-pushed
the
pearson/PAE-845
branch
from
6965d8d
to
f765e1d
Compare
Jacatove
approved these changes
Jan 14, 2022
diegomillan
approved these changes
Feb 3, 2022
Squirrel18
requested changes
Feb 11, 2022
Comment on lines
502
to
504
| <div class="prerequisites"> | ||
| You must successfully complete <a href="${ecommerce_payment_page}?sku=${student_not_enrollment_in_requirement}">${Text(_("{prc_display}")).format( | ||
| prc_display=course_requirements['courses'][0]['display'],)}</a> before you begin this course. |
There was a problem hiding this comment.
Use the same syntax as the existing code. @anfbermudezme
Squirrel18
requested changes
Feb 11, 2022
Comment on lines
+503
to
+512
| <p class="tip"> | ||
| ${Text(_("You must successfully complete {link_start}{prc_display}{link_end} before you begin this course.")).format( | ||
| link_start=HTML('<a href="{ecommerce_payment_page}?sku={student_not_enrollment_in_requirement}">').format( | ||
| ecommerce_payment_page=ecommerce_payment_page, | ||
| student_not_enrollment_in_requirement=student_not_enrollment_in_requirement, | ||
| ), | ||
| link_end=HTML('</a>'), | ||
| prc_display=course_requirements['courses'][0]['display'], | ||
| )} | ||
| </p> |
There was a problem hiding this comment.
Use the same syntax as the existing code. @anfbermudezme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on hold down due to business decisions
To improve the learner experience, Following the logic:
For this, add backend functionality to sort courses_requirements_not_met variable if the learner is enrolled and if the learnor is not enrolled find the sku for verified mode of the course requirement, to redirect the link:
For this it's necessary pull the PR's https://github.com/Pearson-Advance/pearson-core/pull/25 and Pearson-Advance/edx-platform#59.
Also in the course about view for the course with prerequisites the links have the same behavior of the learner dashboard, that means, About course if the learner is enrolled and basket sku if the learner is not enrolled.