Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-notes/warnings/errors in base packages #3196

Merged
merged 26 commits into from
Jan 3, 2024
Merged

fix-notes/warnings/errors in base packages #3196

merged 26 commits into from
Jan 3, 2024

Conversation

moki1202
Copy link
Collaborator

No description provided.

infotroph
infotroph reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@infotroph infotroph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! A few suggestions that I think should make CI happier, plus one place code order could matter

moki1202 and others added 13 commits July 13, 2023 16:00
@moki1202 @infotroph
Update base/settings/R/MultiSettings.R
32c6e7e 
Co-authored-by: Chris Black <[email protected]>
@moki1202 @infotroph
Update base/settings/R/check.all.settings.R
19b5ca8 
Co-authored-by: Chris Black <[email protected]>
@moki1202 @infotroph
Update base/settings/R/MultiSettings.R
ab92118 
Co-authored-by: Chris Black <[email protected]>
@moki1202 @infotroph
Update base/settings/R/MultiSettings.R
c917555 
Co-authored-by: Chris Black <[email protected]>
@moki1202 @infotroph
Update base/settings/R/addSecrets.R
b5fb4e9 
Co-authored-by: Chris Black <[email protected]>
@moki1202 @infotroph
Update base/settings/R/fix.deprecated.settings.R
b819735 
Co-authored-by: Chris Black <[email protected]>
@moki1202 @infotroph
Update base/settings/R/listToXml.R
316be28 
Co-authored-by: Chris Black <[email protected]>
@moki1202 @infotroph
Update base/settings/R/listToXml.R
d1b7f72 
Co-authored-by: Chris Black <[email protected]>
@moki1202 @infotroph
Update base/settings/R/listToXml.R
475b268 
Co-authored-by: Chris Black <[email protected]>
@moki1202 @infotroph
Update base/settings/R/update.settings.R
215258b 
Co-authored-by: Chris Black <[email protected]>
@moki1202 @infotroph
Update base/utils/R/write.config.utils.R
524cc42 
Co-authored-by: Chris Black <[email protected]>
@moki1202 @infotroph
Update base/utils/R/write.config.utils.R
216eb88 
Co-authored-by: Chris Black <[email protected]>
@moki1202
fixed comments
5917ec7
@moki1202 moki1202 self-assigned this Jul 16, 2023
@moki1202 moki1202 marked this pull request as ready for review November 4, 2023 06:47
@infotroph infotroph added this pull request to the merge queue Jan 3, 2024
Merged via the queue into PecanProject:develop with commit 20dfc2b Jan 3, 2024
7 of 12 checks passed
@infotroph infotroph mentioned this pull request Feb 17, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infotroph infotroph infotroph approved these changes

Assignees

@moki1202 moki1202

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moki1202 @infotroph