Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: use pak instead of confirm_deps for dependency installation #3367

Closed
wants to merge 2 commits into from

Conversation

infotroph
Copy link
Member

Description

EXPERIMENTAL, NEEDS TESTING: Use pak::local_install_deps() instead of our confirm_deps script.

Before merging, need to show that local_install_deps (1) behaves the same as confirm_deps with respect to installation behavior, and (2) does not query overeagerly for updates to dependencies. Recall that the original impetus for confirm_deps was devtools::install_deps making too many queries to remote repos that we'd already checked earlier in the process. My read of the documentation suggests we should expect pak to be better about this, but I have not yet checked. Probably the easiest way to check would be by running the install process inside a container instrumented to monitor outgoing IP requests.

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@infotroph
Copy link
Member Author

When testing: Check whether pak retains the same behavior as remotes::install_deps with respect to choosing a CRAN repository, viz. 'try repositories in the order they are specified and stop when the version requirement is satisfied, even if a newer version is available from a repo later in the list'. We rely very heavily on this behavior to avoid version hell in the older rocker images.

@infotroph infotroph changed the title WIP: use pak insead of confirm_deps for dependency installation WIP: use pak instead of confirm_deps for dependency installation Sep 21, 2024
@infotroph
Copy link
Member Author

Closing this until I have a chance to actually test it -- #3366 seems to have fixed the biggest current pain point in confirm_deps, so I'm no longer in as much of a hurry to replace it.

@infotroph infotroph closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant