Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] health check fixes #3377

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

infotroph
Copy link
Member

Description

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@robkooper robkooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

Copy link
Member

@dlebauer dlebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any guidelines for when we should use the --no-install-recommends flag for apt-get? It seems to be used inconsistently (~50:50) in our Docker images.

@robkooper
Copy link
Member

I try to use it as much as possible. The recommended packages are often good for normal use, but we want to try and keep the image as small as possible, hence the --no-recommends

@infotroph infotroph merged commit 584963f into PecanProject:develop Sep 12, 2024
16 of 22 checks passed
@infotroph infotroph deleted the healthcheck-fixes branch September 12, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants