Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manually updated docs that should have gone with e31bc0aa6bd0d461b776… #3384

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

dlebauer
Copy link
Member

I made a minor edit in e31bc0a but didn't run make document

Copy link
Member

@mdietze mdietze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated file seems to be missing a closing }

@mdietze
Copy link
Member

mdietze commented Sep 17, 2024

Current failure seems unrelated to David's changes. Any guesses @infotroph @robkooper

Run docker/login-action@v3
Error: Username and password required

@infotroph
Copy link
Member

infotroph commented Sep 17, 2024

All the Docker GHA jobs fail at the moment for PRs opened from external forks, because GitHub (correctly!) doesn't share our repository secrets with those runs (otherwise people could exfiltrate secrets just by opening PRs from forks they control).

@robkooper is working on this; not sure if there's an ETA for a fix yet. See https://pecanproject.slack.com/archives/C8RD9BRLK/p1725833043616009

bottom line: If the Docker checks are the only ones failing then it's OK to merge.

@infotroph infotroph merged commit 74f1d41 into PecanProject:develop Sep 17, 2024
15 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants