Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set hostname for all services in Compose file #3387

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

infotroph
Copy link
Member

Needed by rabbitmq to persist queues correctly (because hostname is used in cluster name), but nice to have elsewhere just so you can tell where you are when logged in to a container.

Description

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Needed by rabbitmq to persist queues correctly (because hostname is used in cluster name)
but nice to have elsewhere just so you can tell where you are when logged in to a container.
@infotroph infotroph merged commit 89709f9 into PecanProject:develop Sep 26, 2024
16 of 22 checks passed
@infotroph infotroph deleted the set-hostnames branch September 26, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants