Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes in PEcAn.all #3388

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

infotroph
Copy link
Member

@infotroph infotroph commented Sep 30, 2024

Description

Resolving some issues seen when running package checks in a newer R version:

  • avoid leaving temp variables behind in package datasets
  • save an expensive extra call to package_info
  • Make did not need to be treating all other packages as prereqs for check/test/doc
  • A little more cleanup of check messages

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

* avoid leaving temp variables behind in package datasets
* save an expensive extra call to package_info
* Make did not need to be treating all other packages as prereqs for check/test/doc
* A little more cleanup of check messages
@infotroph infotroph merged commit cf02f05 into PecanProject:develop Oct 1, 2024
16 of 22 checks passed
@infotroph infotroph deleted the pecan-version-datafix branch October 1, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants