-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): linux/amd64 platform issue in docker compose #3436
base: develop
Are you sure you want to change the base?
fix(docker): linux/amd64 platform issue in docker compose #3436
Conversation
docker-compose.prod.yml
Outdated
@@ -3,6 +3,7 @@ services: | |||
# webserver to handle all traffic. This can use let's encrypt to generate a SSL cert. | |||
traefik: | |||
image: "traefik:v2.9" | |||
platform: linux/amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not all images need platform, only those that don't have an arm component.
@@ -73,6 +75,7 @@ services: | |||
# ---------------------------------------------------------------------- | |||
bety: | |||
image: pecan/bety:${BETY_VERSION:-latest} | |||
platform: linux/amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has arm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check to see what images (most) need amd64
@robkooper yes i have fixed this.It's working fine on my side.Could you please review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm if my comments about restart
is correct? Other than that everything else seems good to me.
@Sweetdevil144 Can you verify if any changes required now? |
@robkooper i have added linux/amd64 for all services that need it. Please check if anything else needs to be improved before proceeding with docker-compose up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AritraDey-Dev your branch is out of date with the base branch can you please fix it
yes i have updated it. |
fixes #3415
Description
Fix Docker container pull errors on
linux/arm64/v8
.Motivation and Context
Some images lack
arm64
support; forcingamd64
works but breaks RabbitMQ.Review Time Estimate
Types of changes
Checklist