Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update docker image #409

Merged
merged 7 commits into from
May 7, 2024
Merged

[ENH] Update docker image #409

merged 7 commits into from
May 7, 2024

Conversation

mattcieslak
Copy link
Contributor

Updates aslprep_build to something in line with other current nipreps. This updates to

  • Newer FreeSurfer
  • Python 3.11
  • micromamba-based installation of fsl and aslprep

@mattcieslak mattcieslak requested a review from tsalo May 6, 2024 14:00
.circleci/config.yml Outdated Show resolved Hide resolved
@tsalo
Copy link
Member

tsalo commented May 6, 2024

I just don't get it:

./"codecov"  create-commit -t <redacted>
info - 2024-05-06 19:24:53,769 -- ci service found: circleci
warning - 2024-05-06 19:24:53,776 -- No config file could be found. Ignoring config.
info - 2024-05-06 19:24:53,915 -- Process Commit creating complete
error - 2024-05-06 19:24:53,916 -- Commit creating failed: {"detail":"Invalid token header. No credentials provided."}
./"codecov"  create-report -t <redacted>
info - 2024-05-06 19:24:54,826 -- ci service found: circleci
warning - 2024-05-06 19:24:54,832 -- No config file could be found. Ignoring config.
info - 2024-05-06 19:24:54,900 -- Process Report creating complete
error - 2024-05-06 19:24:54,900 -- Report creating failed: {"detail":"Invalid token header. No credentials provided."}
./codecov  do-upload -t <redacted> -n "18236"   -f /src/coverage/coverage.xml
info - 2024-05-06 19:24:55,777 -- ci service found: circleci
warning - 2024-05-06 19:24:55,783 -- No config file could be found. Ignoring config.
warning - 2024-05-06 19:24:55,790 -- xcrun is not installed or can't be found.
warning - 2024-05-06 19:24:55,790 -- gcov is not installed or can't be found.
warning - 2024-05-06 19:24:55,792 -- No coverage data found to transform
warning - 2024-05-06 19:24:55,802 -- Some files were not found --- {"not_found_files": ["/src/coverage/coverage.xml"]}
info - 2024-05-06 19:24:55,807 -- Found 0 coverage files to report
Error: No coverage reports found. Please make sure you're generating reports successfully.

Exited with code exit status 1

.circleci/config.yml Outdated Show resolved Hide resolved
This was referenced May 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (5b37756) to head (4cc858d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
+ Coverage   79.60%   84.34%   +4.74%     
==========================================
  Files          37       37              
  Lines        3986     3986              
  Branches      562        0     -562     
==========================================
+ Hits         3173     3362     +189     
+ Misses        630      624       -6     
+ Partials      183        0     -183     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.circleci/config.yml Outdated Show resolved Hide resolved
@tsalo
Copy link
Member

tsalo commented May 7, 2024

@mattcieslak it looks like the old CodeCov orb still works, so I'll merge this once CI passes and I'll try running PNC through it ASAP. I have a separate PR for the CodeCov orb (#410).

@tsalo tsalo added the maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. label May 7, 2024
@tsalo tsalo merged commit b2112bb into main May 7, 2024
25 checks passed
@tsalo tsalo deleted the enh/update-image branch May 7, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants