Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QSIPrep-specific tests #5

Merged
merged 13 commits into from
Aug 12, 2024
Merged

Remove QSIPrep-specific tests #5

merged 13 commits into from
Aug 12, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 9, 2024

Closes none. The one test that combines preprocessing and reconstruction is dsdti_topup. Probably need to split that one up into preprocessing- and reconstruction-specific versions.

Changes proposed in this pull request

  • Remove all tests that are preprocessing-specific.

@tsalo tsalo added the testing label Aug 9, 2024
@tsalo
Copy link
Member Author

tsalo commented Aug 9, 2024

@mattcieslak do you have ideas on what to do with dsdti_topup?

@tsalo tsalo requested a review from mattcieslak August 9, 2024 15:59
Copy link
Contributor

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple things that should be deletable.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
qsirecon/tests/utils.py Outdated Show resolved Hide resolved
qsirecon/tests/utils.py Outdated Show resolved Hide resolved
@tsalo tsalo merged commit b48bbc9 into main Aug 12, 2024
17 checks passed
@tsalo tsalo deleted the drop-prep-tests branch August 12, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants