Drop Docker wrapper #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
- Coverage 32.18% 32.17% -0.01%
==========================================
Files 56 56
Lines 6937 6936 -1
Branches 917 917
==========================================
- Hits 2233 2232 -1
Misses 4610 4610
Partials 94 94 ☔ View full report in Codecov by Sentry. |
mattcieslak
approved these changes
Aug 16, 2024
| @@ -391,7 +391,6 @@ jobs: | |||
| echo "the command ``git fetch --tags --verbose`` and push" | |||
| echo "them to your fork with ``git push origin --tags``" | |||
| fi | |||
| sed -i -E "s/(__version__ = )'[A-Za-z0-9.-]+'/\1'${CIRCLE_TAG:-$THISVERSION}'/" wrapper/qsirecon_container/qsirecon_docker.py | |||
| sed -i -E "s/(var version = )'[A-Za-z0-9.-]+'/\1'${CIRCLE_TAG:-$THISVERSION}'/" docs/citing.rst | |||
There was a problem hiding this comment.
Note to self: Change this in the docs PR
There was a problem hiding this comment.
This file is gone in the docs PR
mattcieslak
pushed a commit
that referenced
this pull request
Aug 16, 2024
* Drop the Docker and Singularity wrappers. * Keep dropping wrappers.
mattcieslak
pushed a commit
that referenced
this pull request
Aug 16, 2024
* Drop the Docker and Singularity wrappers. * Keep dropping wrappers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #50.
Changes proposed in this pull request