Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QSIPrep-specific parameters and Config elements #6

Merged
merged 31 commits into from
Aug 13, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 9, 2024

Closes #16.

Changes proposed in this pull request

  • Remove the following CLI parameters and their associated config attributes:
    • --skip-bids-validation
    • --anat-only / workflow.anat_only
    • --ignore / workflow.ignore
    • --skip-anat-based-spatial-normalization / execution.skip_anat_based_spatial_normalization
    • --anat-modality / workflow.anat_modality
    • --dwi-denoise-window / workflow.dwi_denoise_window
    • --denoise-method / workflow.denoise_method
    • --unringing-method / workflow.unringing_method
    • --dwi-no-biascorr / workflow.dwi_no_biascorr
    • --b1-biascorrect-stage / workflow.b1_biascorrect_stage
    • --no-b0-harmonization / workflow.no_b0_harmonization
    • --denoise-after-combining / workflow.denoise_after_combining
    • --separate-all-dwis / workflow.separate_all_dwis
    • --distortion-group-merge / workflow.distortion_group_merge
    • --anatomical-template / workflow.anatomical_template
    • --b0-to-t1w-transform / workflow.b0_to_t1w_transform
    • --intramodal-template-iters / workflow.intramodal_template_iters
    • --intramodal-template-transform / workflow.intramodal_template_transform
    • --b0-motion-corr-to / workflow.b0_motion_corr_to
    • --hmc-transform / workflow.hmc_transform
    • --hmc-model / workflow.hmc_model
    • --eddy-config / workflow.eddy_config
    • --shoreline-iters / workflow.shoreline_iters
    • --pepolar-method / workflow.pepolar_method
    • --fmap-bspline / workflow.fmap_bspline
    • --fmap-no-demean / workflow.fmap_demean
    • --use-syn-sdc / workflow.use_syn_sdc
    • --force-syn / workflow.force_syn
    • --recon-only / execution.recon_only
    • --recon-input / execution.recon_input
  • Remove the following config attributes:
    • execution.output_layout
    • execution.qsirecon_dir
    • execution.run_preproc_and_recon
    • execution.task_id
    • workflow.cifti_output
    • workflow.do_reconall
    • workflow.dwi_only
  • Initially remove but then add back in:
    • --b0-threshold / workflow.b0_threshold
    • --skip-odf-reports / execution.skip_odf_reports
    • --output-resolution / workflow.output_resolution

Copy link
Contributor

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple unintuitive options have to be added back but otherwise looks perfect

qsirecon/config.py Outdated Show resolved Hide resolved
qsirecon/config.py Show resolved Hide resolved
b1_biascorrect_stage = None
"""The stage of processing at which to apply B1 bias correction. Either "final" (after
resampling), "none" (skipped entirely) or "legacy" (before concatenation)."""
cifti_output = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see a ScalarMapper writing to cifti sometime in the future

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hoping that, by that time, we'll have CIFTIs defined in --output-spaces instead.

qsirecon/config.py Show resolved Hide resolved
qsirecon/cli/parser.py Show resolved Hide resolved
qsirecon/cli/parser.py Outdated Show resolved Hide resolved
qsirecon/cli/parser.py Outdated Show resolved Hide resolved
@mattcieslak mattcieslak merged commit 3604b96 into main Aug 13, 2024
17 checks passed
@mattcieslak mattcieslak deleted the drop-prep-arguments branch August 13, 2024 19:17
mattcieslak added a commit that referenced this pull request Aug 13, 2024
mattcieslak added a commit that referenced this pull request Aug 14, 2024
* Remove dwi, anatomical, and fieldmap workflows.

* Remove lots of unused interfaces.

* Update __init__.py

* Remove more.

* Do more.

* Update __init__.py

* Add init_output_grid_wf back in.

* Remove QSIPrep-specific parameters and Config elements (#6)

---------

Co-authored-by: Matt Cieslak <[email protected]>

---------

Co-authored-by: Matt Cieslak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] output-resolution shouldn't be mandatory if --recon-input is used
2 participants