Calculate smoothed ALFF from smoothed BOLD #1124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1124 +/- ##
==========================================
- Coverage 83.41% 83.38% -0.03%
==========================================
Files 54 54
Lines 6704 6694 -10
Branches 928 927 -1
==========================================
- Hits 5592 5582 -10
Misses 871 871
Partials 241 241 ☔ View full report in Codecov by Sentry. |
tsalo
commented
Apr 24, 2024
|
|
||
| compute_smoothed_alff = pe.Node( | ||
| ComputeALFF(TR=TR, low_pass=low_pass, high_pass=high_pass), | ||
| mem_gb=mem_gb["resampled"], |
There was a problem hiding this comment.
I was getting TypeError: '>' not supported between instances of 'dict' and 'float' because it was originally setting mem_gb as the mem_gb dictionary instead of the appropriate value.
Hunting down the problem was tough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1132, but addresses a request from @erikglee.
Changes proposed in this pull request
init_alff_wfand use that to calculate the smoothed ALFF instead smoothing the ALFF image calculated from the unsmoothed BOLD data.init_alff_wfinstead of using the interpolated data and censoring it within the workflow.