Upgrade qml.lie_closure to handle dense matrices
#6811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6811 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 483 484 +1
Lines 46119 46193 +74
=======================================
+ Hits 45934 46008 +74
Misses 185 185 ☔ View full report in Codecov by Sentry. |
…o dla_lie_closure_dense
…o dla_lie_closure_dense
…o dla_lie_closure_dense
DSGuala
reviewed
Jan 20, 2025
dwierichs
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Nice and thorough job, @Qottmann 🎉
This basically looks good to go for me, just with the change dense -> matrix pending on the earlier files (by order of git diff :D)
I am wondering whether the trace inner product should be a qml.math feature?
Co-authored-by: David Wierichs <[email protected]>
|
@DSGuala do you want to give this another look before I merge? :) |
…o dla_lie_closure_dense
AntonNI8
reviewed
Feb 13, 2025
DSGuala
approved these changes
Feb 25, 2025
Co-authored-by: Diego <[email protected]>
…I/pennylane into dla_lie_closure_dense
…o dla_lie_closure_dense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading from labs functionality
labs.dla.lie_closure_denseis integrated into the logic ofqml.lie_closureAlso adding
qml.pauli.trace_inner_productas a utility function for Pauli matrices and operators.Integrate lie closure dense to qml lie closure [sc-81965]