Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve and tidy implementation of hadamard gradient #6928
base: master
Are you sure you want to change the base?
Improve and tidy implementation of hadamard gradient #6928
Changes from 24 commits
95823e0
da2275e
4bc4bed
68fe169
c322699
ca082cd
6d78732
252a88a
0bc9750
f239100
6c62750
fcd8896
179444e
371961d
23edfe1
a085872
4a2e033
47b5e15
2527025
a604245
9d6bdad
81017da
ba9c768
875c7e4
3f6ca1f
cf719eb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be agnostic about list-versus-tuple consistently in our gradient spec. In the case of the hadamard grad, we initially create lists because we are iterating and pushing things in to the list. As much as I prefer tuples to lists, we shouldn't have to iteratively re-construct the whole data structure just to put it back into a tuple.