-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Capture] Capture the single_qubit_fusion
transform
#6945
Conversation
Hello. You may have forgotten to update the changelog!
|
…o capture_single_qubit_fusion
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6945 +/- ##
========================================
Coverage 99.60% 99.60%
========================================
Files 484 484
Lines 46141 46243 +102
========================================
+ Hits 45957 46059 +102
Misses 184 184 ☔ View full report in Codecov by Sentry. |
…o capture_single_qubit_fusion
…o capture_single_qubit_fusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @PietropaoloFrisoni, very thorough testing 💪 💯
I had a number of minor technical suggestions and questions.
I think the occasional reordering through the transform is not problematic, but I would like to make sure that I understand where exactly it comes in :) Do we have other plxpr transforms that do such shenanigans? 😁
Co-authored-by: David Wierichs <[email protected]>
…e laptop) [ci skip]
…o capture_single_qubit_fusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass through, everything looks great to me so far! I think I might have some ways to clean-up my merge rotations PR now ... 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another pass through! 😎
Co-authored-by: Andrija Paurevic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all my comments so thoroughly, @PietropaoloFrisoni 💯
Nice job! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice to me! Great job 🚀
Co-authored-by: Andrija Paurevic <[email protected]>
Context:
single_qubit_fusion
can now be captured. That is, it can be applied whenqml.capture.enabled
isTrue
.Description of the Change: As above.
Benefits: One more transform can be applied with the new capture feature.
Possible Drawbacks: The order of operations might change compared to the non-captured version of this function, but this does not affect the correctness of the result.
Related GitHub Issues: None.
[sc-83906]