-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve wire ordering in tapering workflows #6954
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6954 +/- ##
=======================================
Coverage 99.59% 99.60%
=======================================
Files 484 484
Lines 46193 46196 +3
=======================================
+ Hits 46008 46012 +4
+ Misses 185 184 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @obliviateandsurrender. Just to clarify, this is just to make tapering JAX-JIT compatible?
@austingmhuang this is to fix the wire ordering issue with tapered Hamiltonians as raised by a user in the forum. Jax-jit support is additional. |
Do we have a test case for this wire ordering issue? |
Linking the Forum thread where the issue was first identified (for future reference). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @obliviateandsurrender.
Context: Improves wire ordering in
_taper_pauli_sentence
Description of the Change: Fixes an edge case related to Identities and simplifies some blocks using arithmetic.
Benefits:
Possible Drawbacks:
Related GitHub Issues: