Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wire ordering in tapering workflows #6954

Merged
merged 14 commits into from
Feb 26, 2025

Conversation

obliviateandsurrender
Copy link
Contributor

Context: Improves wire ordering in _taper_pauli_sentence

Description of the Change: Fixes an edge case related to Identities and simplifies some blocks using arithmetic.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.60%. Comparing base (4af2597) to head (403da73).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6954   +/-   ##
=======================================
  Coverage   99.59%   99.60%           
=======================================
  Files         484      484           
  Lines       46193    46196    +3     
=======================================
+ Hits        46008    46012    +4     
+ Misses        185      184    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@austingmhuang austingmhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @obliviateandsurrender. Just to clarify, this is just to make tapering JAX-JIT compatible?

@obliviateandsurrender
Copy link
Contributor Author

@austingmhuang this is to fix the wire ordering issue with tapered Hamiltonians as raised by a user in the forum. Jax-jit support is additional.

@austingmhuang
Copy link
Contributor

@austingmhuang this is to fix the wire ordering issue with tapered Hamiltonians as raised by a user in the forum. Jax-jit support is additional.

Do we have a test case for this wire ordering issue?

@CatalinaAlbornoz
Copy link
Contributor

Linking the Forum thread where the issue was first identified (for future reference).

Copy link
Contributor

@austingmhuang austingmhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obliviateandsurrender obliviateandsurrender merged commit b3f7558 into master Feb 26, 2025
46 checks passed
@obliviateandsurrender obliviateandsurrender deleted the tapering_wires branch February 26, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants