Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve QROM decomposition if no work wires provided #6967

Merged
merged 8 commits into from
Feb 25, 2025
Merged

Conversation

KetpuntoG
Copy link
Contributor

@KetpuntoG KetpuntoG commented Feb 14, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the doc/releases/changelog-dev.md file, summarizing the
    change, and including a link back to the PR.

  • The PennyLane source code conforms to
    PEP8 standards.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Fix this bug [https://github.com//issues/6968]
[sc-84591]
Description of the Change:

Check if work wires are used and choose the correct decomposition based on that.

Benefits:

More efficient decomposition

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (043be3e) to head (1ef5857).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6967   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files         483      483           
  Lines       46119    46119           
=======================================
  Hits        45934    45934           
  Misses        185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small comments

@KetpuntoG KetpuntoG requested a review from Jaybsoni February 24, 2025 18:16
@soranjh soranjh changed the title QROM uses unnecessary gates if non work wires provided Improve QROM decomposition if no work wires provided Feb 24, 2025
Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small fix in changelog

@KetpuntoG KetpuntoG enabled auto-merge (squash) February 25, 2025 22:21
@KetpuntoG KetpuntoG merged commit 329965e into master Feb 25, 2025
46 checks passed
@KetpuntoG KetpuntoG deleted the fixing_qrom_bug branch February 25, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants