Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Capture] Improve unitary_to_rot tests #6977

Merged
merged 6 commits into from
Feb 25, 2025
Merged

Conversation

andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Feb 19, 2025

Context:

After some internal discussion, testing strategies have been updated to follow,

class TestXInterpreter:
    ...

def test_X_plxpr_to_plxpr():
    ...

class TestHigherOrderPrimitives:
    ...

class TestExpandPlxprTransform:
    ...

Description of the Change:

Added tests to cover,

  • Traced arguments as input (wires or unitaries)

Deleted redundant tests. Improved test suite to only test was they are supposed to be testing.

Benefits: Improved testing.

Possible Drawbacks: None.

[sc-84724]

This comment was marked as resolved.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (7c44146) to head (696027d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6977   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files         483      483           
  Lines       46119    46119           
=======================================
  Hits        45934    45934           
  Misses        185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@andrijapau andrijapau enabled auto-merge (squash) February 25, 2025 20:40
@andrijapau andrijapau merged commit 043be3e into master Feb 25, 2025
46 checks passed
@andrijapau andrijapau deleted the fix-unit-to-rot-tests branch February 25, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants