[Capture] Switch from binding qnode_kwargs to execution_config
#6991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Feb 21, 2025
albi3ro
commented
Feb 21, 2025
…yLaneAI/pennylane into qnode-prim-execution-config
andrijapau
reviewed
Feb 21, 2025
andrijapau
reviewed
Feb 21, 2025
mudit2812
reviewed
Feb 21, 2025
albi3ro
commented
Feb 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6991 +/- ##
==========================================
- Coverage 99.59% 99.59% -0.01%
==========================================
Files 483 483
Lines 46069 46066 -3
==========================================
- Hits 45884 45881 -3
Misses 185 185 ☔ View full report in Codecov by Sentry. |
andrijapau
approved these changes
Feb 24, 2025
mudit2812
reviewed
Feb 24, 2025
mudit2812
approved these changes
Feb 24, 2025
|
Blocked by PennyLaneAI/pennylane-lightning#1067 Will merge once that goes in. |
albi3ro
added a commit
to PennyLaneAI/pennylane-lightning
that referenced
this pull request
Feb 24, 2025
**Context:** In PennyLaneAI/pennylane#6991 we are adding an `execution_config` kwarg to `Device.eval_jaxpr`. We need to make sure this change doesn't break lightning. **Description of the Change:** Adds an `execution_config : Optional[ExecutionConfig] = None` keyword argument to `Device.eval_jaxpr`. **Benefits:** Lightning won't break when that change gets merged into pennylane. The lightning device jaxpr execution can be configured in the future. **Possible Drawbacks:** **Related GitHub Issues:** [sc-84916] --------- Co-authored-by: ringo-but-quantum <[email protected]> Co-authored-by: Amintor Dusko <[email protected]>
Co-authored-by: Pietropaolo Frisoni <[email protected]>
Co-authored-by: Mudit Pandey <[email protected]>
josephleekl
pushed a commit
to PennyLaneAI/pennylane-lightning
that referenced
this pull request
Feb 25, 2025
**Context:** In PennyLaneAI/pennylane#6991 we are adding an `execution_config` kwarg to `Device.eval_jaxpr`. We need to make sure this change doesn't break lightning. **Description of the Change:** Adds an `execution_config : Optional[ExecutionConfig] = None` keyword argument to `Device.eval_jaxpr`. **Benefits:** Lightning won't break when that change gets merged into pennylane. The lightning device jaxpr execution can be configured in the future. **Possible Drawbacks:** **Related GitHub Issues:** [sc-84916] --------- Co-authored-by: ringo-but-quantum <[email protected]> Co-authored-by: Amintor Dusko <[email protected]>
albi3ro
added a commit
to PennyLaneAI/catalyst
that referenced
this pull request
Feb 26, 2025
**Context:** In [pennylane PR #6991](PennyLaneAI/pennylane#6991) we switched from binding a `qnode_kwargs` to an `execution_config` with `qnode_prim`. **Description of the Change:** Update the call siganture for `qnode_prim`. **Benefits:** Consistency with catalyst and pennylane. **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: erick-xanadu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
As the capture workflow is getting more complicated, we should start using the well-defined
ExecutionConfigobject instead of the ambiguous and unspecifiedqnode_kwargs.We also need to start passing the
execution_configto the device, as that information is needed for handling mid circuit measurements.Description of the Change:
Switches from binding a
qnode_kwargsdictionary to anexecution_configobject.Benefits:
Easier to manage the configuration of a workflow. Can specify MCM configuration info for device execution.
Possible Drawbacks:
Technically a breaking change, but a breaking change to an experimental project.
Related GitHub Issues:
[sc-84916]