Specialize _givens_matrix to jax interface using jax.jit #7013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erick-xanadu
force-pushed
the
eochoa/2025-02-26/givens
branch
from
7ffec9d to
bc3d39d
Compare
|
Hello. You may have forgotten to update the changelog!
|
erick-xanadu
force-pushed
the
eochoa/2025-02-26/givens
branch
from
bc3d39d to
32dfbe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: _givens_matrix is a function that can be
jax.jited. It is called several many times. Usingjax.jitcan speed up the compilation process.Description of the Change: Specialize
_givens_matrixandjax.jitif the interface is JAX.Benefits: Speeding up jax and catalyst.
Possible Drawbacks: Code size.
Related GitHub Issues: