-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define and integrate plxpr device jvps #7019
Open
albi3ro
wants to merge
15
commits into
master
Choose a base branch
from
capture-device-jvps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yLaneAI/pennylane into qnode-prim-execution-config
Co-authored-by: Mudit Pandey <[email protected]>
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7019 +/- ##
==========================================
- Coverage 99.60% 99.60% -0.01%
==========================================
Files 484 484
Lines 46249 46277 +28
==========================================
+ Hits 46065 46092 +27
- Misses 184 185 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Description of the Change:
Device.jaxpr_jvp
method to the device APIDefaultQubit.jaxpr_jvp
for both adjoint and backpropexecution_config
before callingqnode_prim.bind
. This way we don't have to setup multiple times.Benefits:
Device provided jvps with program capture.
Backprop jvps fit in to the workflow structure a bit more smoothly.
Possible Drawbacks:
Trying to figure out how to best test backprop versus adjoint dervatives.
Related GitHub Issues:
[sc-82170] [sc-82168]
Replaces #6905