Handling MCM in captured transforms
#7020
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
PietropaoloFrisoni
changed the title
interpreting mcm method to PlxprInterpret
PietropaoloFrisoni
changed the title
interpreting mcm method to PlxprInterpretinterpret_mcm_eqn method to the PlxprInterpreter class/
PietropaoloFrisoni
changed the title
interpret_mcm_eqn method to the PlxprInterpreter class/interpret_mcm_eqn method to the PlxprInterpreter class
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7020 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 484 484
Lines 46305 46315 +10
=======================================
+ Hits 46122 46132 +10
Misses 183 183 ☔ View full report in Codecov by Sentry. |
PietropaoloFrisoni
changed the title
interpret_mcm_eqn method to the PlxprInterpreter classMCM in captured transforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Plxpr transforms such as
cancel_inverses, which use dictionaries to hold ops that have been traced, but not yet applied, are giving incorrect results with MCMs in the circuit.Description of the Change: We apply the previously stored operators before applying the MCM, so that the result is correct.
Benefits: Correct result.
Possible Drawbacks: As for other higher-order primitives, we risk that some optimizations are not applied. For example, in the case of
cancel inverses, if we have an operationOon wire0. a MCM on wire1, and then the inverse ofOon wire0, we are not cancelingOwith its inverse (although we could, because the measurement is on a different wire).This is a further enhancement that can be implemented in the future for all the higher-order primitives and all the quantum transforms with program capture enabled.
Related GitHub Issues: None.
Related Shortcut Stories: [sc-85404]