Changing name from compute_plxpr_decomposition to compute_qfunc_decomposition
#7022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietropaoloFrisoni
changed the title
compute_plxpr_decompositioncompute_plxpr_decomposition to compute_qfunc_decomposition
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7022 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 484 484
Lines 46249 46307 +58
=======================================
+ Hits 46065 46123 +58
Misses 184 184 ☔ View full report in Codecov by Sentry. |
josephleekl
approved these changes
Feb 28, 2025
isaacdevlugt
approved these changes
Feb 28, 2025
Co-authored-by: Isaac De Vlugt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change: Changing name from
compute_plxpr_decompositiontocompute_qfunc_decomposition, as decided during previous discussionsRelated GitHub Issues: None
[sc-83707]