Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating previously captured transforms #7023

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

PietropaoloFrisoni
Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni commented Feb 28, 2025

Context: This PR updates a few transforms with the following improvements.

  • Ensure that plxpr transforms are not using pop when getting args/kwargs, plus validating the kwargs provided to the interpreter

  • Remove logic that checks if prim_type=="transform" from all captured transforms, because we know that the interpreter will not see a transform as a primitive

Description of the Change: As above.

Benefits: More consistent implementation

Possible Drawbacks: More consistent logic.

Related GitHub Issues: None

[sc-85311]
[sc-85245]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.60%. Comparing base (4690439) to head (f38b481).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7023   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files         485      485           
  Lines       46365    46369    +4     
=======================================
+ Hits        46182    46186    +4     
  Misses        183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant