Updating previously captured transforms #7023
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: This PR updates a few transforms with the following improvements.
Ensure that plxpr transforms are not using
pop
when gettingargs/kwargs
, plus validating thekwargs
provided to the interpreterRemove logic that checks if
prim_type=="transform"
from all captured transforms, because we know that the interpreter will not see atransform
as a primitiveDescription of the Change: As above.
Benefits: More consistent implementation
Possible Drawbacks: More consistent logic.
Related GitHub Issues: None
[sc-85311]
[sc-85245]