-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix qml.Controlled.has_sparse_matrix
#7025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🙂 🚀
qml.Controlled.has_sparse_matrix
Co-authored-by: Andrija Paurevic <[email protected]>
Still wondering why was it alwasy true before?.... |
Co-authored-by: Andrija Paurevic <[email protected]>
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7025 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 484 484
Lines 46249 46252 +3
=======================================
+ Hits 46065 46068 +3
Misses 184 184 ☔ View full report in Codecov by Sentry. |
Context:
Controlled.has_sparse_matrix
was always trueDescription of the Change:
Fix
Controlled.has_sparse_matrix
.Benefits:'
Controlled.has_sparse_matrix
is accurate.Unblock #6883
Possible Drawbacks:
Related GitHub Issues:
Fixes #7024 [sc-85452]