Raise an error for MCMs nested in Conditionals #7027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The current methods for of mid-circuit measurement processing don't support applying a mid-circuit measurement conditionally. This was not within the scope of the implementation for any of these methods, so we don't expect it to work - however, we would prefer to return clear error messages, and we don't want to be returning incorrect results.
Currently,
qml.cond(m, qml.measure)(wire)
either raises a difficult to parse error (in the case of deferred measurements and analytical execution), or returns incorrect results (in the case oftree-traversal
,one-shot
, and deferred measurements withshots
).Description of the Change:
We add validation in the
midcircuit_measurements
transform, checking for conditional mcms and raising an error. Specificmcm_method
s can be made to pass this validation check in the future if support for conditional mcms are added to the method; for now, we disallow it completely.Benefits:
We don't return incorrect results or raise cryptic errors.
Possible Drawbacks:
It adds one more iteration over the operations for validation 🤷♀️
Related GitHub Issues:
None, but sc stories [sc-84177] and [sc-84178]