Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues mentioned on HackerNews #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lucasburlingham
Copy link

Hello there!

I was browsing hackernews.com (as many do) and came across the post located at https://news.ycombinator.com/item?id=39206843. I was disappointed to see the comments about the site having easily fixable issues (yet major if you're trying to sell something to someone - yes I know it's free but you're selling a product for free in return for adoption of said product) and no one stepping up to fix them. They were indeed simple fixes, but it took someone willing and able to actually do them.

Please review this pull request and merge what you'd like. I've tried to keep the changes I've made simple yet impactful. I am from the USA so if the grammar/spelling don't exactly match up to what is used in the UK, please don't be surprised. If there are obvious errors (there shouldn't be as nothing pops up when I run the dev instance!), please let me know. This is my first time using Next.JS, React, etc. and typically prefer sites like this to be simple static sites with HTML, CSS, and JS only, though it doesn't make much of a difference in the end except for saving a couple KB per user and a couple ms off 3G loading times if it can be cached by Cloudflare or similar.

1m view of changes

  • Spelling and grammatical errors corrected (as mentioned by beastcoast)
  • Fixed responsive navigation for mobile users
  • Added hover: styling to most links to indicate there's something there. This helps with accessibility and makes the site more interesting.
  • Reworded key language to make it more marketable, more obvious to the user what Peppermint does (also beastcoast)
  • Fixed broken/incorrect links (About goes to "Our Mission" section, DB Tech != NetworkChuck, etc.)

I still have to use Peppermint myself, though I'll keep it in the back of my head. I work at a help desk and wish we had something like this. (Right now we have the process of "Knock Knock, come fix my stuff" and it really isn't efficient at all. Go US Military Branch).

Thank you, and I wish you the best. Keep up the good work.

Lucas Burlingham (anything you like at lucas burlingham dot me).

Copy link

netlify bot commented Feb 3, 2024

Deploy Preview for peppy-scone-2dbbf7 ready!

Name Link
🔨 Latest commit 69d120c
🔍 Latest deploy log https://app.netlify.com/sites/peppy-scone-2dbbf7/deploys/65bea3fda96e970008fa5122
😎 Deploy Preview https://deploy-preview-1--peppy-scone-2dbbf7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant