Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS fixes #133

Merged
merged 2 commits into from
Aug 15, 2020
Merged

HTTPS fixes #133

merged 2 commits into from
Aug 15, 2020

Conversation

Filyus
Copy link

@Filyus Filyus commented Aug 15, 2020

Just try to use certificate like this (from package.json of https://github.com/rixo/rollup-plugin-svelte-hot package):
nollup -c --hot --https --key keys/localhost.key --cert keys/localhost.cert --port 5000 --content-base ./public

I fixed this, so no more errors when loading or changing the page.

@PepsRyuu
Copy link
Owner

Can you explain the problem in more detail? What error was being thrown?

Also I would move the server argument to the end of the nollupDevMiddleware constructor. As it's currently written, it's a significant breaking change.

@Filyus
Copy link
Author

Filyus commented Aug 15, 2020

The error is when loading a page:
WebSocket connection to 'wss://localhost:5000/__hmr' failed: Error during WebSocket handshake: Unexpected response code: 404
in this line:
ws = new WebSocket(protocol + __nollup__global__.location.host + '/__hmr');
of the file:
nollup\lib\plugin-hmr.js

@Filyus
Copy link
Author

Filyus commented Aug 15, 2020

No more breaking changes now.

@PepsRyuu
Copy link
Owner

Looks good to me! Thanks for the fix! :)

@PepsRyuu PepsRyuu merged commit ac0b241 into PepsRyuu:master Aug 15, 2020
@PepsRyuu
Copy link
Owner

Released in 0.13.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants