Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop unused prereq Test::Deep #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

drop unused prereq Test::Deep #22

wants to merge 1 commit into from

Conversation

haarg
Copy link
Member

@haarg haarg commented Jan 3, 2023

Test::Deep was imported in several tests, but none of its functions were actually being used.

@haarg
drop unused prereq Test::Deep
5780281 
Test::Deep was imported in several tests, but none of its functions were
actually being used.
@rjbs rjbs self-requested a review January 5, 2023 22:38
rjbs
rjbs approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@rjbs rjbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks correct to me. I cloned and tested the change. I also saw that Test::Deep wasn't removed from Makefile.PL, but I see that the @DAGOLDEN bundle will rebuild it and copy the file from the build into the repo again. 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjbs rjbs rjbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haarg @rjbs