Fix Perl version lookup with Module::CoreList #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a distribution declares a dependency on '5.010' Perl, inc::Module::Install dies in Module::Install::Admin::ScanDeps::scan_dependencies() with: Module::CoreList has no information on perl 5.010 at /usr/lib/perl5/ site_perl/5.10.1/Module/Install/Admin/ScanDeps.pm line 25. This is because %Module::CoreList::version is indiced only with some arbitrary versions and normalized numeral versions only. E.g. it contains an entry for 5.005, 5.005000 and 5.010000 but no entry of 5.010. This patch fixes the lookup by converting a version string into a numeral. https://rt.cpan.org/Public/Bug/Display.html?id=71565 Perl-Toolchain-Gang#47
|
It really should use version->parse($perl_version)->numify, rather than the regex and such. But I guess that would require bundling version.pm. This is nice and unobtrusive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a distribution declares a dependency on '5.010' Perl,
inc::Module::Install dies in
Module::Install::Admin::ScanDeps::scan_dependencies() with:
Module::CoreList has no information on perl 5.010 at /usr/lib/perl5/ site_perl/5.10.1/Module/Install/Admin/ScanDeps.pm line 25.
This is because %Module::CoreList::version is indiced only with some
arbitrary versions and normalized numeral versions only. E.g. it
contains an entry for 5.005, 5.005000 and 5.010000 but no entry of 5.010.
This patch fixes the lookup by converting a version string into
a numeral.
https://rt.cpan.org/Public/Bug/Display.html?id=71565
#47