Skip to content

Commit

Permalink
Make perlapi args consistent wrt const for sv_catsv
Browse files Browse the repository at this point in the history
These all end up calling the same base level function whose arguments
include const.  This changes the other functions so that everything
matches.
  • Loading branch information
khwilliamson committed Sep 2, 2024
1 parent 0aa33fc commit 196b782
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 13 deletions.
12 changes: 6 additions & 6 deletions embed.fnc
Original file line number Diff line number Diff line change
Expand Up @@ -3068,23 +3068,23 @@ Adfpv |void |sv_catpvf_mg |NN SV * const sv \
|...
Adp |void |sv_catpv_mg |NN SV * const dsv \
|NULLOK const char * const sstr
AMbdp |void |sv_catpvn |NN SV *dsv \
AMbdp |void |sv_catpvn |NN SV * const dsv \
|NN const char *sstr \
|STRLEN len
Adp |void |sv_catpvn_flags|NN SV * const dsv \
|NN const char *sstr \
|const STRLEN len \
|const I32 flags
AMbdp |void |sv_catpvn_mg |NN SV *dsv \
AMbdp |void |sv_catpvn_mg |NN SV * const dsv \
|NN const char *sstr \
|STRLEN len
AMbdp |void |sv_catsv |NN SV *dsv \
|NULLOK SV *sstr
AMbdp |void |sv_catsv |NN SV * const dsv \
|NULLOK SV * const sstr
Adp |void |sv_catsv_flags |NN SV * const dsv \
|NULLOK SV * const sstr \
|const I32 flags
AMbdp |void |sv_catsv_mg |NN SV *dsv \
|NULLOK SV *sstr
AMbdp |void |sv_catsv_mg |NN SV * const dsv \
|NULLOK SV * const sstr
Adp |void |sv_chop |NN SV * const sv \
|NULLOK const char * const ptr
: Used only in perl.c
Expand Down
4 changes: 2 additions & 2 deletions mathoms.c
Original file line number Diff line number Diff line change
Expand Up @@ -256,15 +256,15 @@ Perl_sv_catpvn_mg(pTHX_ SV *dsv, const char *sstr, STRLEN len)
*/

void
Perl_sv_catsv(pTHX_ SV *dsv, SV *sstr)
Perl_sv_catsv(pTHX_ SV *dsv, SV * const sstr)
{
PERL_ARGS_ASSERT_SV_CATSV;

sv_catsv_flags(dsv, sstr, SV_GMAGIC);
}

void
Perl_sv_catsv_mg(pTHX_ SV *dsv, SV *sstr)
Perl_sv_catsv_mg(pTHX_ SV *dsv, SV * const sstr)
{
PERL_ARGS_ASSERT_SV_CATSV_MG;

Expand Down
8 changes: 4 additions & 4 deletions proto.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sv.h
Original file line number Diff line number Diff line change
Expand Up @@ -2242,7 +2242,7 @@ immediately written again.
sv_setsv_flags(dsv, ssv, SV_GMAGIC|SV_DO_COW_SVSETSV)
/*
=for apidoc_defn Am|void|sv_setsv_nomg|SV *dsv|SV *ssv
=for apidoc_defn Am|void|sv_catsv_nomg|SV *dsv|SV *ssv
=for apidoc_defn Am|void|sv_catsv_nomg|SV * const dsv|SV * const sstr
=cut
*/
#define sv_setsv_nomg(dsv, ssv) sv_setsv_flags(dsv, ssv, SV_DO_COW_SVSETSV)
Expand Down

0 comments on commit 196b782

Please sign in to comment.