Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation warnings about UTF8_\w+_PERL_EXTENDED #22649

Open
wants to merge 1 commit into
base: blead
Choose a base branch
from

Conversation

khwilliamson
Copy link
Contributor

Commit b66abe3 added these symbols to two #defines, but neglected to remove the special casing that had been used when it wasn't in them.


  • This set of changes does not require a perldelta entry.

Commit b66abe3 added these symbols to
two #defines, but neglected to remove the special casing that had been
used when it wasn't in them.
Copy link
Contributor

@tonycoz tonycoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test that should have picked this up?

eg. is_strict_utf8_string() would never be called here from is_utf8_string_flags() though it should have been with the right flags.

@jkeenan
Copy link
Contributor

jkeenan commented Oct 10, 2024

Is there a test that should have picked this up?

Yes, I would like to know that. In addition, how would I configure a perl build so as to reproduce the compilation warnings mentioned in the subject?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants