Allow a separate domain name for auth #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the auth (keycloak) configuration live at a separate domain name from the web (PDC implementation) domain name. Separate certificates are now expected by the `.env.example`, `compose.yml`, and `proxy.conf.example` files. This change creates a logical separation of concerns but keeps the implementation on the same host for now. In future a change of (tangible) hosting for either backend service can be made with minimal disruption from a user perspective. Issue #66 Deploy Keycloak at auth.pdco
jasonaowen
approved these changes
Mar 2, 2023
|
@jasonaowen Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the auth (keycloak) configuration live at a separate domain name from the web (PDC implementation) domain name. Separate certificates are now expected by the
.env.example,compose.yml, andproxy.conf.examplefiles. This change creates a logical separation of concerns but keeps the implementation on the same host for now. In future a change of (tangible) hosting for either backend service can be made with minimal disruption from a user perspective.Issue #66 Deploy Keycloak at auth.pdco