Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing multi-line title, image reduction, Objective-C compatibility, font configuration, and padding. Added support for "next" button instead of "skip", as well. Adding delegate callback for providing access to content view controllers when displayed/redisplayed. #28

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fixing multi-line title, image reduction, Objective-C compatibility, font configuration, and padding. Added support for "next" button instead of "skip", as well. Adding delegate callback for providing access to content view controllers when displayed/redisplayed. #28

wants to merge 10 commits into from

Commits on Dec 6, 2017

  1. Fixing multi-line title.

    @benguild
    benguild authored Dec 6, 2017
    Configuration menu
    Copy the full SHA
    a8bcedb View commit details
    Browse the repository at this point in the history

  2. Fixing jagged aliasing when scaling-down large images.

    @benguild
    benguild authored Dec 6, 2017
    Configuration menu
    Copy the full SHA
    c0a82f3 View commit details
    Browse the repository at this point in the history

  3. Providing basic Objective-C compatibility.

    @benguild
    benguild authored Dec 6, 2017
    Configuration menu
    Copy the full SHA
    6c849cf View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2017

  1. Increasing padding on text. 

    Tested this on iPhone 5s and iPhone 6, and the 10pt margin looked too thin. I conferred with others and we all agreed 14pt looks much more natural.

On shorter strings this has no effect, but when wrapping it looks much nicer. Hope you agree.
    @benguild
    benguild authored Dec 7, 2017
    Configuration menu
    Copy the full SHA
    bb2767b View commit details
    Browse the repository at this point in the history

  2. Removing increased padding on top/bottom constraints. 

    Actually, since the horizontal constraints were the only concern, I reverted the two vertical constraints. I think this should be fine now.
    @benguild
    benguild authored Dec 7, 2017
    Configuration menu
    Copy the full SHA
    b84f611 View commit details
    Browse the repository at this point in the history

  3. Adding support for configurable "Next" button instead of "Skip" butto… 

    …n. Guarding against a crash.
    @benguild
    benguild committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    29392f2 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2017

  1. Adding support for changing fonts.

    @benguild
    benguild committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    45f4053 View commit details
    Browse the repository at this point in the history

  2. Removing problematic line count limitation.

    @benguild
    benguild committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    a3a0140 View commit details
    Browse the repository at this point in the history

  3. Enabling a couple more properties for Objective-C.

    @benguild
    benguild committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    f814bac View commit details
    Browse the repository at this point in the history

  4. Adding optional delegate method for when displaying steps.

    @benguild
    benguild committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    a7e958d View commit details
    Browse the repository at this point in the history