-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing multi-line title, image reduction, Objective-C compatibility, font configuration, and padding. Added support for "next" button instead of "skip", as well. Adding delegate callback for providing access to content view controllers when displayed/redisplayed. #28
Open
benguild
wants to merge
10
commits into
PhilippeBoisney:master
Choose a base branch
from
benguild:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Dec 6, 2017
-
Configuration menu - View commit details
-
Copy full SHA for a8bcedb - Browse repository at this point
Copy the full SHA a8bcedbView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0a82f3 - Browse repository at this point
Copy the full SHA c0a82f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c849cf - Browse repository at this point
Copy the full SHA 6c849cfView commit details
Commits on Dec 7, 2017
-
Tested this on iPhone 5s and iPhone 6, and the 10pt margin looked too thin. I conferred with others and we all agreed 14pt looks much more natural. On shorter strings this has no effect, but when wrapping it looks much nicer. Hope you agree.
Configuration menu - View commit details
-
Copy full SHA for bb2767b - Browse repository at this point
Copy the full SHA bb2767bView commit details -
Removing increased padding on top/bottom constraints.
Actually, since the horizontal constraints were the only concern, I reverted the two vertical constraints. I think this should be fine now.
Configuration menu - View commit details
-
Copy full SHA for b84f611 - Browse repository at this point
Copy the full SHA b84f611View commit details -
Adding support for configurable "Next" button instead of "Skip" butto…
…n. Guarding against a crash.
Configuration menu - View commit details
-
Copy full SHA for 29392f2 - Browse repository at this point
Copy the full SHA 29392f2View commit details
Commits on Dec 8, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 45f4053 - Browse repository at this point
Copy the full SHA 45f4053View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3a0140 - Browse repository at this point
Copy the full SHA a3a0140View commit details -
Configuration menu - View commit details
-
Copy full SHA for f814bac - Browse repository at this point
Copy the full SHA f814bacView commit details -
Configuration menu - View commit details
-
Copy full SHA for a7e958d - Browse repository at this point
Copy the full SHA a7e958dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.