Add background fade to the opening and dismissing animation #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you Daniel! There is another small issue with the animation, when the alert appears: the semi-transparent alert background appears all at once, rather than smoothly with the animation. It's pretty trivial but just to save you time: I fixed it is by setting background's alpha to 0 when it is configured, and then set its alpha to 0.5 as part of the UIView animation inside animateForOpening(). |
|
A little delayed but the change is in! Thank you for the suggestion it looks a lot better now! |
chickdan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the alertView is dismissed it fades away, then after it fades the background view is removed causing a rather jarring animation as the background suddenly disappears. With this PR the background now fades away along with the alertView for a much smoother transition.