Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cats Effect IO type inference #2459

Merged
merged 4 commits into from
Jul 29, 2021
Merged

Fix Cats Effect IO type inference #2459

merged 4 commits into from
Jul 29, 2021

Conversation

yangzai
Copy link
Contributor

@yangzai yangzai commented Jun 19, 2021 •
edited
Loading

As mention in this comment the generalisation of implicits to provide Executor/Functor typeclass instances for all types with Async/CatsFunctor instances loses IO specificity and implicit precedence priority, making client execution infer to the default Future effect return type. This makes using the IO effect type very unwieldy, having to explicitly state all type parameters for client execution.

This PR brings back IO type inference without losing support for other Async effect type.

@sksamuel
Copy link
Collaborator

This is a little beyond my knowledge. What's the tl;dr of the change ?

@sksamuel
Copy link
Collaborator

Triggered

@sksamuel sksamuel merged commit 9066f73 into Philippus:master Jul 29, 2021
@yangzai yangzai deleted the hy-ce-implicits branch July 29, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sksamuel sksamuel sksamuel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yangzai @sksamuel